Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add MAC / host name to unnamed device name #146

Closed
johannrichard opened this issue Nov 30, 2020 · 0 comments · Fixed by #167
Closed

[FEATURE] Add MAC / host name to unnamed device name #146

johannrichard opened this issue Nov 30, 2020 · 0 comments · Fixed by #167
Assignees
Labels
enhancement New feature or request

Comments

@johannrichard
Copy link
Owner

Describe the feature requested
Most devices from myStrom don't let the user set a name directly on the device. In Order to make them more recognisable (and in line with their own naming), we should use the MAC address (or parts thereof) when setting the name in HomeKit.

Examples and context

e.g. a myStrom-Switch-F00BAD would be named the same or myStrom Switch F00BAD.

Alternatively, the host name could be resolved and if something meaningful is returned, could be used.

E.g. kitchen.my.local would be named Kitchen.

@johannrichard johannrichard self-assigned this Nov 30, 2020
@johannrichard johannrichard added the enhancement New feature or request label Nov 30, 2020
@johannrichard johannrichard added this to To do in Homebridge Plugin via automation Nov 30, 2020
johannrichard added a commit that referenced this issue Dec 5, 2020
- last needed change
- implements #146
@johannrichard johannrichard linked a pull request Dec 7, 2020 that will close this issue
Homebridge Plugin automation moved this from To do to Done Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant