Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use offset tables for validation #130

Open
johannesvollmer opened this issue May 12, 2021 · 0 comments
Open

Use offset tables for validation #130

johannesvollmer opened this issue May 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@johannesvollmer
Copy link
Owner

What can be improved or is missing?

Invalid files can be detected without too much overhead (1 sort operation), which detects invalid files much (?) faster.

Implementation Approach

When sorted, the offset table will not only tell us the start of a chunk, but also the size of the chunk (except the last one). As each chunk also declares a size on its own, the size of the chunk can be double checked with the offset table.

Also, the distance between each offset table entry is at most header.max_tile_byte_size + c where c is the fixed size meta data in the chunk. This can be checked too.

@johannesvollmer johannesvollmer added the enhancement New feature or request label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant