Fix scrollToHash failing on links #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the issue with <a...> anchor tags not scrolling to their corresponding hash when clicked. The version of the function `scrollToHash` in templates/index.html is using `getElementById`, which fails for anchor tags such as `<a name="foo">`; whereas the homonymously named function in templates/limit.html (using `getElementsByName` instead) does work correctly. This commit merges these two functions with the same name but differing function body into the correctly working version from templates/limit.html, and moves it to templates/base.html, such that it can be shared and extended by the Flask templates accordingly. Note that as this change modified the templates, the tests must be regenerated by running the tests/regenerate.py script in order for them to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #368
This change fixes the issue with
<a ...>anchor tags not scrolling to their corresponding hash when clicked.Description of changes:
The version of the function
scrollToHashin templates/index.html is usinggetElementById, which fails for anchor tags such as<a name="foo">; whereas the homonymously named function in templates/limit.html (usinggetElementsByNameinstead) does work correctly.This commit merges these two functions with the same name but differing function body into the correctly working version from templates/limit.html, and moves it to templates/base.html, such that it can be shared and extended by the Flask templates accordingly.
Note that as this change modified the templates, the tests must be regenerated by running the tests/regenerate.py script in order for them to pass.