Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the last linter issues Dockerfile (windows is solved) #55

Open
joergi opened this issue Oct 6, 2020 · 3 comments
Open

Fixing the last linter issues Dockerfile (windows is solved) #55

joergi opened this issue Oct 6, 2020 · 3 comments
Labels
code quality Hacktoberfest Hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted linter

Comments

@joergi
Copy link
Owner

joergi commented Oct 6, 2020

I fixed a lot of the the linter issues.

but the last ones I have no idea how to catch them:

for the windows file
https://github.com/joergi/MagPiDownloader/runs/1202964598?check_suite_focus=true#step:4:59
image

for the Dockerfile:
https://github.com/joergi/MagPiDownloader/runs/1216756825?check_suite_focus=true#step:4:172
image

It would be super great, if someone can help here.
even if you can just fix one of this 2 issues... THANKS

@rubemlrm
Copy link
Contributor

rubemlrm commented Oct 7, 2020

For the first case i think that we can fix that with the following options:
imagem
Since the error that is been throwing is relative to the Bash linter that it's been running for the powershell script for some reason.

@joergi
Copy link
Owner Author

joergi commented Oct 7, 2020

@rubemlrm https://stackoverflow.com/questions/64234725/linter-shows-error-sc1036-for-correct-powershell-script?noredirect=1#comment113588172_64234725
maybe that would be enough to change? (but I haven't looked up yet, what would be better to use)

@joergi
Copy link
Owner Author

joergi commented Oct 7, 2020

Windows issues is solved with PR #57

@joergi joergi changed the title Fixing the last linter issues (Windows + Dockerfile) Fixing the last linter issues ( ~~Windows~~ + Dockerfile) Oct 14, 2022
@joergi joergi changed the title Fixing the last linter issues ( ~~Windows~~ + Dockerfile) Fixing the last linter issues Dockerfile (windows is solved) Oct 14, 2022
@joergi joergi added the linter label Oct 14, 2022
joergi added a commit that referenced this issue Oct 13, 2023
joergi added a commit that referenced this issue Oct 13, 2023
joergi added a commit that referenced this issue Oct 14, 2023
joergi added a commit that referenced this issue Oct 14, 2023
joergi added a commit that referenced this issue Oct 14, 2023
joergi added a commit that referenced this issue Oct 14, 2023
joergi added a commit that referenced this issue Oct 14, 2023
joergi added a commit that referenced this issue Oct 14, 2023
joergi added a commit that referenced this issue Oct 14, 2023
joergi added a commit that referenced this issue Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Hacktoberfest Hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted linter
Projects
None yet
Development

No branches or pull requests

2 participants