Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is wireguard-manager-config used? #169

Open
uhthomas opened this issue May 10, 2024 · 1 comment · May be fixed by #176
Open

Is wireguard-manager-config used? #169

uhthomas opened this issue May 10, 2024 · 1 comment · May be fixed by #176

Comments

@uhthomas
Copy link
Collaborator

uhthomas commented May 10, 2024 •
edited

Describe the bug

I noticed the config map named wireguard-manager-config and cannot find it actually used anywhere?

https://github.com/jodevsa/wireguard-operator/blob/1d1bef4d0d82c0235dbfba3b665f6ebe5fb4260b/config/manager/controller_manager_config.yaml

To Reproduce

N/A

Expected behavior

N/A

Screenshots

N/A

Additional context

N/A
@uhthomas
Copy link
Collaborator Author

I guess another question - should it be used? It looks like most config is set through the CLI.

uhthomas added a commit that referenced this issue May 12, 2024
@uhthomas
chore: remove unused wireguard-manager-config
a634a0a 
Fixes: #169
@uhthomas uhthomas linked a pull request May 12, 2024 that will close this issue
Open
uhthomas added a commit that referenced this issue May 12, 2024
@uhthomas
chore: remove unused wireguard-manager-config
77ce3eb 
Fixes: #169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove unused wireguard-manager-config jodevsa/wireguard-operator
1 participant
@uhthomas