Remove dependency on bash #79

jodevsa · 2023-06-25T20:21:27Z

We are currently relying on bash in the agent to update the iptable rules. This isn't really needed and can be done without bash.
https://github.com/jodevsa/wireguard-operator/blob/main/internal/iptables/iptables.go#L27

iptables-restore was being executed via bash, which was unnecessary. Executing directly is simpler and more reliable. Fixes: jodevsa#79

uhthomas · 2024-05-09T08:41:05Z

Bash is also used in two other places:

wireguard-operator/pkg/wireguard/wireguard.go

Line 75 in 8565ade

    
           bashCommand := fmt.Sprintf("mkdir -p /dev/net && if [ ! -c /dev/net/tun ]; then\n    mknod /dev/net/tun c 10 200\nfi && %s %s", wgUserspaceImplementationFallback, iface)

wireguard-operator/internal/it/suite_test.go

Line 100 in 8565ade

    
           bashCommand := fmt.Sprintf("echo \"%s\" | kubectl apply -n %s --context %s -f -", strings.TrimSpace(strings.ReplaceAll(resource, "\"", "\\\"")), namespace, testKindContextName)

…t with native code There is no reason to use bash, or even to call out to the shell for most of what was happening. Replacing it allows for better error handling, clarity and reliability. Fixes: jodevsa#79

There is no reason to use bash, or even to call out to the shell for most of what was happening. Replacing it allows for better error handling, clarity and reliability. Fixes: jodevsa#79

iptables-restore was being executed via bash, which was unnecessary. Executing directly is simpler and more reliable. Fixes: #79

Fixes: jodevsa#79

#163) Fixes: #79

There is no reason to use bash, or even to call out to the shell for most of what was happening. Replacing it allows for better error handling, clarity and reliability. Fixes: jodevsa#79

jodevsa added the good first issue Good for newcomers label Jun 25, 2023

uhthomas mentioned this issue May 9, 2024

chore(internal/iptables): exec iptables-restore directly #159

Merged

uhthomas mentioned this issue May 9, 2024

chore(pkg/wireguard): replace bash script with native code #161

Open

jodevsa closed this as completed in #159 May 9, 2024

jodevsa pushed a commit that referenced this issue May 9, 2024

chore(internal/iptables): exec iptables-restore directly (#159)

4fb8541

iptables-restore was being executed via bash, which was unnecessary. Executing directly is simpler and more reliable. Fixes: #79

uhthomas mentioned this issue May 9, 2024

remove bash dependency #81

Closed

uhthomas added a commit to uhthomas/wireguard-operator that referenced this issue May 9, 2024

chore(internal/it): replace kubectl apply bash script with direct exec

bac78fd

Fixes: jodevsa#79

uhthomas mentioned this issue May 9, 2024

chore(internal/it): replace kubectl apply bash script with direct exec #163

Merged

uhthomas added a commit to uhthomas/wireguard-operator that referenced this issue May 9, 2024

chore(internal/it): replace kubectl apply bash script with direct exec

a2455b4

Fixes: jodevsa#79

jodevsa pushed a commit that referenced this issue May 9, 2024

chore(internal/it): replace kubectl apply bash script with direct exec (

acd2e77

#163) Fixes: #79

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove dependency on bash #79

Remove dependency on bash #79

jodevsa commented Jun 25, 2023 •

edited

uhthomas commented May 9, 2024

Remove dependency on bash #79

Remove dependency on bash #79

Comments

jodevsa commented Jun 25, 2023 • edited

uhthomas commented May 9, 2024

jodevsa commented Jun 25, 2023 •

edited