Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add support for kotlinx.serialization as JsonMapper #960

Open
gmariotti opened this issue Mar 15, 2024 · 6 comments
Open

[Feature] add support for kotlinx.serialization as JsonMapper #960

gmariotti opened this issue Mar 15, 2024 · 6 comments

Comments

@gmariotti
Copy link

Is your feature request related to a problem? Please describe.
With kotlinx.serialization gaining popularity in the Kotlin space, it would be great to have it as a JsonMapper option in JobRunr and avoid the need to have different type of json libraries in the same project.

Describe the solution you'd like
A configurable JsonMapper that uses kotlinx.serialization is added to JobRunr core or language-support.

Describe alternatives you've considered
The only alternative would be to develop it as a separate project, independent of JobRunr.

Additional context
If it's okay to have it in JobRunr, I'm open to creating a PR for it.

@rdehuyss
Copy link
Contributor

Hi @gmariotti , we're definitely open for PR's. The only important thing to keep in mind is to make sure there are some tests.

@gmariotti
Copy link
Author

Thanks for the fast answer @rdehuyss 🙏 in which module should I develop it? In core, like the other mappers, or in language-support?

@rdehuyss
Copy link
Contributor

I would do it in the language-support module for kotlin 1.9 as it will only be relevant for Kotlin.. If you add a test that extends the Java AbstractJsonMapperTest, I think we're ok (the AbstractJsonMapperTest may have to move to TestFixtures though).

@rdehuyss
Copy link
Contributor

Please also use the v7 branch for your work as we're about to release the first v7 release candidate.

@alexanderpichler-cpi
Copy link

@gmariotti I can help you if you want

@gmariotti
Copy link
Author

@alexanderpichler-cpi I'm hoping to get back to it this weekend, but if I don't, I'll let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants