bugfix: sync category delete and chapters marked as unread. #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When same device is initiating the sync just update the remote that. Signed-off-by: KaiserBh <kaiserbh@proton.me>
|
When this is merged can you please ping me @jobobby04 I need to push the release for the syncyomi server. |
6 tasks
|
I have try this to skip unnecessary restore process: // <-- SyncService.kt
/**
* Sync with remote service.
*
* - Return syncData itself (reference equal) if nothing changed.
* - Return null if sync failed.
*/
open suspend fun doSync(syncData: SyncData): SyncData? {
beforeSync()
val remoteSData = pullSyncData()
val finalSyncData =
if (remoteSData == null || remoteSData.deviceId == syncData.deviceId) {
pushSyncData(syncData)
syncData
} else {
val mergedSyncData = mergeSyncData(syncData, remoteSData)
.copy(deviceId = syncData.deviceId)
pushSyncData(mergedSyncData)
mergedSyncData
}
return finalSyncData
}
// <-- SyncManager.kt
val syncedData = syncService?.doSync(syncData)
if (syncedData === syncData) {
// nothing changed
updateSyncTimestamp()
return
}
val remoteBackup = syncedData?.backup
|
When there is network failure or any sort during downloading just throw exception and stop syncing. Signed-off-by: KaiserBh <kaiserbh@proton.me>
Yea true, that was bad design. Updated the new one will throw exception when downloading fails due to network error. |
kaiserbh
changed the title
People with over 3k library can't sync because we are hitting OOM ```java.util.concurrent.ExecutionException: java.lang.OutOfMemoryError: Failed to allocate a 370950192 byte allocation with 25165824 free bytes and 281MB until OOM, target footprint 333990992, growth limit 603979776```. This should fix that for them but only gdrive. Signed-off-by: KaiserBh <kaiserbh@proton.me>
|
Included in #1155 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When same device is initiating the sync just update the remote that.
This should fix the issue with chapters being marked as unread or category coming back after it's deleted.
closes: #1149