From 667c4fe39ccbcf5c1cd3bb80cf678658ecc64966 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Burak=20Yi=C4=9Fit=20Kaya?= Date: Tue, 5 Sep 2017 00:08:06 +0300 Subject: [PATCH] Fix: make sure all extracted tarballs are r/w enabled (#4301) * Fix: make sure all extracted tarballs are r/w enabled **Summary** Fixes: #992. This issue was supposed to be fixed by #2826 but it was not setting directory permissions wide enough. This patch uses the `readable` and `writable` options provided by the `tar-fs` package which essentially sets everything to `0o777`. **Test plan** N/A * fewer perms --- src/fetchers/tarball-fetcher.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/fetchers/tarball-fetcher.js b/src/fetchers/tarball-fetcher.js index 96170a6be0..c9529aebad 100644 --- a/src/fetchers/tarball-fetcher.js +++ b/src/fetchers/tarball-fetcher.js @@ -67,8 +67,8 @@ export default class TarballFetcher extends BaseFetcher { const extractorStream = gunzip(); const untarStream = tarFs.extract(this.dest, { strip: 1, - dmode: 0o555, // all dirs should be readable - fmode: 0o444, // all files should be readable + dmode: 0o755, // all dirs should be readable + fmode: 0o644, // all files should be readable chown: false, // don't chown. just leave as it is });