Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redesign] Suggestion: Rename "Songs" to "Tracks" #675

Open
lukaslindnermusic opened this issue Apr 5, 2024 · 1 comment
Open

[Redesign] Suggestion: Rename "Songs" to "Tracks" #675

lukaslindnermusic opened this issue Apr 5, 2024 · 1 comment

Comments

@lukaslindnermusic
Copy link

lukaslindnermusic commented Apr 5, 2024

I already mentioned this in the Discussion of the Redesign a few weeks ago, but I think it might be a little bit clearer to have a separate issue for this:

Currently, the tab is called "Song(s)" (as it is also in Jellyfin itself and in a lot of music streaming services... as a composer/musician, I am already triggered by that for years 🤣 ). The problem with this is, that a "song" refers only to a track that has vocals in it, so a recording of a classical symphony, an instrumental jazz standard, a film score etc. would not get called a "Song". And as @Chaphasilor mentioned in the Discussion, "Song" is also not suitable for podcasts and audio books.
I think, "Track(s)" fits way better as it is more generic and can refer to both vocal tracks, instrumental tracks and spoken audio.

Any other opinions about this?
I guess the only valid argument against this is that Jellyfin itself calls it Songs as well and it would be more consistent to stick to it, but I personally would prefer correct names over that.
Apparently, "tracks" is already used for internal references, so only the user-facing stuff had to be renamed.

What do you people think about it?

(If this is easy to do without knowing the whole internal structure of the app and if someone can tell me in which file these strings have to be updated, I would gladly do that work 😊)

@Chaphasilor
Copy link
Collaborator

Hi, finally getting to this. Yeah if you want to go ahead and change the string, feel free to do that! All the strings are in lib/l10n/app_en.arb. You can simply open a PR after replacing the strings so I can take a look and re-generate the needed files.

It would also be good to refactor all variables and classes that use "song" to "track" instead, but that would require a proper development setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants