Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Playback speed #412

Closed
YourSandwich opened this issue Feb 27, 2023 · 5 comments · Fixed by #594
Closed

[Feature Request] Playback speed #412

YourSandwich opened this issue Feb 27, 2023 · 5 comments · Fixed by #594
Labels
good first issue Good for newcomers hacktoberfest Issues available for Hacktoberfest

Comments

@YourSandwich
Copy link

Hi and thank you for developing this awesome app!

I would like to request a playback speed change option.

I'm a speed freak, so please give me an option to get a hearth stroke, I need this 250bpm.
Ideally without changing the pitch of the sound.

@jmshrv
Copy link
Owner

jmshrv commented Feb 27, 2023

This should be easy to add, as just_audio can handle it: https://pub.dev/documentation/just_audio/latest/just_audio/AudioPlayer/setSpeed.html

@Chaphasilor Chaphasilor added good first issue Good for newcomers hacktoberfest Issues available for Hacktoberfest labels Oct 2, 2023
@Chaphasilor Chaphasilor linked a pull request Apr 28, 2024 that will close this issue
@Chaphasilor
Copy link
Collaborator

@YourSandwich this is now available with the latest beta update, 0.9.6. Let me know if you have any issues with it!

@YourSandwich
Copy link
Author

@Chaphasilor Hi, thank you for implementing the feature.
I noticed there is a pretty big delay between changing the speed, but that's not so important.

There is a big quality decrease by increasing the playback speed, at least for songs.
Mostly noticeable at the lower spectrum 20-300hz I was testing at x1.5 and comparing against the game osu!

To make sure osu is not implementing any special filter or something, I've also tried mpv which offers similar quality to osu.
But since from reading the changelog I assume this was primarily implemented for podcasts, I assume music is a second priority.

I hope this can be improved.

Thank you for your contributions <3

@Chaphasilor
Copy link
Collaborator

Chaphasilor commented May 4, 2024

Hi, thanks for the report. I confirmed that it takes almost a second to update the speed, but that sadly isn't handled by Finamp. Same for the audio quality; this is handled by a plugin that applies the speed change using the native implementations on Android and iOS, and not something we do ourself.

So I don't think there's any improvement to be had in that regard 😅

For the upcoming desktop support we are actually using an mpv-based audio backend in some cases, but I'm not sure if a) it supports changing the playback speed or b) it works on Android and iOS. I'll try to remember testing that out at some point...

@YourSandwich
Copy link
Author

Thank you for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues available for Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants