Remove explicit doc links to osmdata pkg

[mpadge]

Hi @jmaspons, congratulations on submitting this package to rOpenSci! It'll be a great addition to the OSM ecosystem there. I was trying to debug why checks for this package didn't appear, and discovered that the following lines refer to functions from osmdata, yet that package is neither imported nor suggested here:

osmapiR/R/osm_get_objects.R

Lines 28 to 31 in 6589fc3

	#' @note
	#' For downloading data for purposes other than editing or exploring the history of the objects, perhaps is better to
	#' use the Overpass API. A similar function to download OSM objects by `type` and `id` using Overpass, is implemented in
	#' [osmdata::opq_osm_id()].

osmapiR/R/osmapi_elements.R

Lines 679 to 682 in 6589fc3

	#' @note
	#' For downloading data for purposes other than editing or exploring the history of the objects, perhaps is better to
	#' use the Overpass API. A similar function to download OSM objects by `type` and `id` using Overpass, is implemented in
	#' [osmdata::opq_osm_id()].

osmapiR/R/osmapi_elements.R

Lines 906 to 909 in 6589fc3

	#' @note
	#' For downloading data for purposes other than editing or exploring the history of the objects, perhaps is better to
	#' use the Overpass API. A similar function to download OSM objects by `type` and `id` using Overpass, is implemented in
	#' [osmdata::opq_osm_id()].

osmapiR/R/osmapi_miscellaneous.R

Lines 222 to 224 in 6589fc3

	#' @note
	#' For downloading data for purposes other than editing or exploring the history of the objects, perhaps is better to
	#' use the Overpass API. A similar function to download OSM objects using Overpass, is implemented in [osmdata::opq()].

These become errors because the rOpenSci systems runs roxygen2::roxygenise() or the equivalent devtools::document(), while those are not called in standard rcmdcheck, which is why those checks all pass. roxygen2 has to then parse the function name from the package, which requires the package to be installed. My preferred way around this is to replace, for example,

The function [osmdata::opq()]

with

The \pkg{osmdata} function opq()

The \pkg{...} tag is resolved by roxygen simply by examining available.packages(), regardless of whether or not they are installed, and so does not error. The function name is then just plain code that requires no interpretation. When you've fixed those, feel free to ping the bot to run checks again.

[mpadge]

And BTW, installing the pkgcheck-action in this repo would have helped diagnose that. I'm sure it will help you progress through review if you have that workflow running here too.

[jmaspons]

Thanks, fixed! I will have a look to the pkgcheck-action