Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup option (and method) not working in v4.0.9 #545

Open
Antimated opened this issue Jan 3, 2022 · 7 comments
Open

Cleanup option (and method) not working in v4.0.9 #545

Antimated opened this issue Jan 3, 2022 · 7 comments
Labels

Comments

@Antimated
Copy link

Antimated commented Jan 3, 2022

Issue

I have a demo here: https://codepen.io/Antimated/pen/gOGzpjW. The styles on my .foo DOM element are NOT being cleaned up after the reveal. Not with the cleanupproperty set to "true" nor using the afterReveal method. Am I missing something?

EDIT: Also syncing doesn't seem to work.
EDIT2: Seems te broken from version 4.0.9. 4.0.8 works (cleaning works, not sure about sync)

Environment

  • Operating System: MacOS
  • Browser Version: Chrome Version 96.0.4664.110
  • ScrollReveal Version: 4.0.9
@Antimated Antimated changed the title [BUG] Cleanup option (and method) not working [BUG] Cleanup option (and method) not working in v4.0.9 Jan 4, 2022
@jlmakes jlmakes added the Bug label Jan 9, 2022
@jlmakes jlmakes changed the title [BUG] Cleanup option (and method) not working in v4.0.9 Cleanup option (and method) not working in v4.0.9 Jan 9, 2022
@QuietNoise
Copy link

Confirmed big on Windows Chrome and Firefox.
Also both cleanup option and method work as expected in 4.0.5.

@mattborn
Copy link

Confirmed bug on Mac Safari except clean/cleanup is broken in 4.0.8 for us as well.

@jimmytherrien
Copy link

The clean and destroy functions are not removing generated styles.

@Aurion72
Copy link

Same here, is there still someone who takes care of this package ?

@jlmakes
Copy link
Owner

jlmakes commented Jul 30, 2022

@Aurion72 Yes, some big updates are coming soon.

If there is a problem with versions 4.0.8 and 4.0.9, they are likely regressions introduced to get around CSP violations surfaced by manipulating inline styles directly. So perhaps rolling back to 4.0.7 is a sufficient workaround for the time being.

@Aurion72
Copy link

@Aurion72 Yes, some big updates are coming soon.

If there is a problem with versions 4.0.8 and 4.0.9, they are likely regressions introduced to get around CSP violations surfaced by manipulating inline styles directly. So perhaps rolling back to 4.0.7 is a sufficient workaround for the time being.

I am very happy to hear that, I love this package, any news? :)

@drywall
Copy link

drywall commented Oct 25, 2022

@Aurion72 Yes, some big updates are coming soon.

I was excited to read this but am wondering what was meant by "soon" — hopefully @jlmakes is okay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants