Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter MutualInfoCalculatorMultiVariate significance calculations to specify which variable should be reordered #4

Open
GoogleCodeExporter opened this issue Jul 23, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

The ChannelCalculators talk about reordering the source variable to evaluate 
the statistical significance, but the 
MutualInfoCalculatorMultiVariate.computeAverageLocalOfObservations(int[] 
newOrdering) method reorders the second variable (which is now the 
destination). This is because it used to have source variable as the second 
argument.

Should reorganise this code so that it follows a consistent interpretation 
(reordering the source variable - the first variable). This will necessitate 
shuffling the arguments around in the Kraskov calculators. They are currently 
consistent (MI gives right result, TE calculator uses the variables in the 
correct order) but I want this finalised.



Original issue reported on code.google.com by joseph.lizier on 6 Aug 2012 at 6:38

@GoogleCodeExporter
Copy link
Author

It makes more sense for one to be able to specify which variable is reordered 
rather than have one variable always positioned as the source. This is the 
approach that we've taken with the ConditionalMutualInformationCalculator now

Original comment by joseph.lizier on 14 Jan 2013 at 11:41

  • Changed title: Alter MutualInfoCalculatorMultiVariate significance calculations to specify which variable should be reordered

@GoogleCodeExporter
Copy link
Author

Need to make this change for the discrete.ConditionalMutualInformationCalculator

Original comment by joseph.lizier on 17 Oct 2013 at 6:39

@GoogleCodeExporter
Copy link
Author

The Kraskov MI calculators currently shuffle the "destination" variable instead 
of the source (done by other MI calculators). This will still return an 
equivalent distribution (it's MI, not conditional MI in play here), but is 
inconsistent.

Original comment by joseph.lizier on 26 Mar 2014 at 5:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants