Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InventoryHtmlReportRenderer#section and InventoryHtmlReportRenderer#link should be non-private #299

Open
Vampire opened this issue Apr 24, 2024 · 0 comments

Comments

@Vampire
Copy link
Contributor

Vampire commented Apr 24, 2024

The InventoryHtmlReportRenderer is nicely customizable with a subclass, as all kinds of methods are protected and can be overridden to do fine-grained customizing.

But for two reasons said methods should have promoted visibility.

  1. In the customizing it might be handy to also use these methods.
  2. Even if you to not want to use those methods, you get MissingMethodExceptions when non-overridden methods try to call them, due to the Groovy duck-typing and not using static compilation. At least if you use a static language like Kotlin to override the class. I didn't try whether it would work when using Groovy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant