Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move overrides functionality up the architecture #294

Open
Vampire opened this issue Apr 16, 2024 · 0 comments
Open

Move overrides functionality up the architecture #294

Vampire opened this issue Apr 16, 2024 · 0 comments
Assignees

Comments

@Vampire
Copy link

Vampire commented Apr 16, 2024

If you have dependencies with Unkown License, the documented built-in way to handle them is using the overrides file.
But the overrides file is only available for the two inventory reports.
And furthermore, using the overrides file does only change what is displayed but does in no way influence the sections a dependency is displayed under, so "Unkown License" stays "Unkown License" even if supplied by overrides file.
In all other things like the JSON report, or the checkLicense report file, the overrides are not considered at all as they are exclusive to the inventory reports.

I think it would make more sense to have some builtin filter that allows to specify some file that contains license information by coordinates, just like you can supply a file to the LicenseBundleNormalizer filter, or as allowedLicensesFile.

This way all further steps should be able to benefit from the supplemented information, including dependencies landing in the right sections in the inventory reports and the check task not complaining anymore about unknown license.

@jk1 jk1 self-assigned this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants