You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After troubleshooting the plugin behavior with excludeBoms set to true and several BOMs still being present in the report, I've noticed that the logic that determines whether current module is a BOM actually looks only at the module name:
This is very fragile and IMO not at all expected with the property being described as If set to true, then all boms will be excluded from the report in the readme.
BOMs that are not named as expected by the plugin are quite common, and the issue can be easily reproduced using something like this:
After troubleshooting the plugin behavior with
excludeBoms
set totrue
and several BOMs still being present in the report, I've noticed that the logic that determines whether current module is a BOM actually looks only at the module name:Gradle-License-Report/src/main/groovy/com/github/jk1/license/LicenseReportExtension.groovy
Line 98 in 877442e
This is very fragile and IMO not at all expected with the property being described as If set to true, then all boms will be excluded from the report in the readme.
BOMs that are not named as expected by the plugin are quite common, and the issue can be easily reproduced using something like this:
Running
generateLicenseReport
will generate a report withorg.springframework.boot:spring-boot-dependencies
present in the report.Could you provide a proper implementation of this feature or at the very least clearly describe its limitations?
The text was updated successfully, but these errors were encountered: