Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When syncing a source to a destination not all columns get copied #1040

Open
antonioorct opened this issue Aug 30, 2023 · 5 comments
Open

When syncing a source to a destination not all columns get copied #1040

antonioorct opened this issue Aug 30, 2023 · 5 comments
Assignees

Comments

@antonioorct
Copy link

antonioorct commented Aug 30, 2023

Version: Jitsu Next @ latest

Source postgres table:
image

Destination postgres table:
image

The source postgres table contains only one row whose scope and workspaceId fields are null (these fields are missing from the destination table). So it seems to be only happening when a column in all rows are null.

I assume this is an issue with Airbyte but I still want to check in.

@antonioorct
Copy link
Author

Going into the json_schema fetched after a call to /discover I get the following for this source table:

{...
    "json_schema": {
        "type": "object",
        "properties": {
            "id": {
                "type": "string"
            },
            "scope": {
                "type": "string"
            },
            "userId": {
                "type": "string"
            },
            "createdAt": {
                "type": "string",
                "format": "date-time",
                "airbyte_type": "timestamp_without_timezone"
            },
            "updatedAt": {
                "type": "string",
                "format": "date-time",
                "airbyte_type": "timestamp_without_timezone"
            },
            "preferences": {
                "type": "string"
            },
            "workspaceId": {
                "type": "string"
            }
        }
    }
}

I'm not sure if it's related that none of the fields have got any property to indicate nullable.

@absorbb
Copy link
Contributor

absorbb commented Aug 31, 2023

Look like something that we can fix on our side. We will take a look

@absorbb absorbb self-assigned this Aug 31, 2023
@absorbb absorbb added this to To do in Current Tasks via automation Aug 31, 2023
@vklimontovich
Copy link
Contributor

@absorbb is this still an issue?

@vklimontovich
Copy link
Contributor

It's not a bug, it's how Jitsu is designed at the moment. The connector sends data to Bulker as an array (stream) of JSON object, and Bulker omits all null values. Also, it create columns on demand, so as a result the columns are not being created. But once the column will have a non-null value at least in one record coming in, it will be created.

That being said, I agree that the current design is not ideal. We will make a change that will remove null value deletion if the data is coming from Jitsu Connectors

@absorbb
Copy link
Contributor

absorbb commented Dec 5, 2023

Fixed in jitsucom/bulker:v1.0.1

@absorbb absorbb closed this as completed Dec 5, 2023
Current Tasks automation moved this from To do to Done Dec 5, 2023
@absorbb absorbb reopened this Dec 5, 2023
Current Tasks automation moved this from Done to In progress Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Current Tasks
In progress
Development

No branches or pull requests

3 participants