Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uvicorn version #5999

Open
JoanFM opened this issue Jul 31, 2023 · 10 comments
Open

Update uvicorn version #5999

JoanFM opened this issue Jul 31, 2023 · 10 comments

Comments

@JoanFM
Copy link
Member

JoanFM commented Jul 31, 2023

Release of uvicorn 0.23.2 is making our tests hang because of the way how we handle websocket Gateway.

For now, we have fixed the uvicorn version, but it would be ideal to find the reason and unpin the version to profit from new benefits from it

@jina-bot
Copy link
Member

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

@JoanFM
Copy link
Member Author

JoanFM commented Nov 23, 2023

@MimicTester1307 please assign yourself here

@MimicTester1307
Copy link

@MimicTester1307 please assign yourself here

@JoanFM I can't seem to assign myself, as I am not a collaborator. Please assign the issue to me.

@JoanFM
Copy link
Member Author

JoanFM commented Nov 23, 2023

I do not find how, but do not worry, u can start working on it

@MimicTester1307
Copy link

Alright, thanks

@MimicTester1307
Copy link

MimicTester1307 commented Dec 22, 2023

Hi @JoanFM. In trying to reproduce the error, I found a couple of things and have some questions. Maybe it's due to my local setup, so I want to clarify:

  1. the build is tested against Python versions 3.7 & 3.8, right? Are there plans to upgrade to a later version?
  2. the current version of Jina depends on docarray <=0.21.0, but it seems that the build is configured to download the latest version of docarray. This caused some tests to fail. Please find attached a sample image below:

image

I will downgrade to the recommended version of docarray, but I just wanted to point this out.

@JoanFM
Copy link
Member Author

JoanFM commented Dec 22, 2023

for 1. We could chnage in the future, but is not related to this issur.

for 2. Jina is compatible with every docarray version, but we had so many tests with docarray 0.21.0 that we kept most of the tests unchanged and we install that version in our ci/cd

@MimicTester1307
Copy link

MimicTester1307 commented Dec 22, 2023

Yes, the python version isn't related. I was just curious.

I see. Somehow it was the latest version of docarray that was installed in my environment. Maybe along the line the tests can be updated to use the latest version of docarray. In the meantime, I'll downgrade my version and just work on this issue. Thanks

@JoanFM
Copy link
Member Author

JoanFM commented Dec 22, 2023

it is a really big effort to change to the docarray version, and it would not add so much value.

@jina-bot
Copy link
Member

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

@jina-bot jina-bot added the Stale label Mar 22, 2024
@JoanFM JoanFM removed the Stale label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants