Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

fix: update usage of SimpleIndexer to new API #726

Open
cristianmtr opened this issue Sep 21, 2021 · 3 comments
Open

fix: update usage of SimpleIndexer to new API #726

cristianmtr opened this issue Sep 21, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@cristianmtr
Copy link
Contributor

cristianmtr commented Sep 21, 2021

The SimpleIndexer is used in a lot of examples.

However, it is using the old API.

The task is to check all the examples that use SimpleIndexer still work and fix the version to a specific version, like /v0.3.

SimpleIndexer hub image: https://hub.jina.ai/executor/zb38xlt4

@m4rtinkoenig
Copy link

m4rtinkoenig commented Sep 27, 2021

Hi @cristianmtr,

I tested the wikipedia-sentence example.

It works as expected and the test passed.

Screenshot 2021-09-27 at 01 32 00

Affected example

  • wikipedia-sentences
  • multires-lyrics-search
  • cross-modal-search
  • audio-to-audio-search

@cristianmtr
Copy link
Contributor Author

Hey @m4rtinkoenig

Thanks for helping. Are you going to take over this ticket completely?

It means checking these examples, fixing any issues, and then fixing the tag of the SimpleIndexer to specific tag, like v0.3

@m4rtinkoenig
Copy link

m4rtinkoenig commented Sep 28, 2021

Yes, but I am currently working on another issue on jina core. I just wanted to post my progress and see if CI tests pass :D If anyone wants to take over feel free and leave a short note

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants