Skip to content
This repository has been archived by the owner on Dec 25, 2020. It is now read-only.

To-do list for pokemon.py #1

Open
3 of 5 tasks
jimsug opened this issue Apr 29, 2016 · 4 comments
Open
3 of 5 tasks

To-do list for pokemon.py #1

jimsug opened this issue Apr 29, 2016 · 4 comments
Assignees

Comments

@jimsug
Copy link
Owner

jimsug commented Apr 29, 2016

  • Indicate in some way whether the data used was fresh or cached
  • Find some way to present type match-ups in a neat, concise manner
  • Handle 5XX responses differently to 4XX responses
  • Maybe some other options for data - blurb, sprite, etc. There's a lot of data available, may as well exploit it
  • Change the type display to just type1/type2
@MTRNord
Copy link

MTRNord commented Jul 15, 2016

I am getting on the task to support multi language support for the pokemon name. Maybe I will get that done maybe not. If it goes well I will send an Pull :)

@MTRNord
Copy link

MTRNord commented Jul 16, 2016

Code for translation is here: https://github.com/MTRNord/pokemon-hangouts-bot-plugins/blob/patch-1/pokemon.py#L171 It does not work completly yet but I am working at it.

@jimsug
Copy link
Owner Author

jimsug commented Aug 2, 2016

@MTRNord

Code for translation is here: https://github.com/MTRNord/pokemon-hangouts-bot-plugins/blob/patch-1/pokemon.py#L171 It does not work completly yet but I am working at it.

There's possibly a case here that if you're using a different language, you could cache the entire dataset of pokemon and then call the API for every pokemon in existence. The issue there is that you'd need to do this for every type, and nature as well - that's probably about 900 calls to the API?

But then - you could make this run in batches, with exponential backoff, and then cache it incredibly heavily - I'm thinking months if not a year or so - new Pokemon aren't released that often.

This is an idea I could work with.

@MTRNord
Copy link

MTRNord commented Aug 2, 2016

I am still working on it and the devs of the API already working on an List over the Api. (I asked them about this). With this API it would be much faster and easier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants