Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unreachable code #14

Open
calumsult opened this issue Oct 27, 2020 · 1 comment
Open

unreachable code #14

calumsult opened this issue Oct 27, 2020 · 1 comment

Comments

@calumsult
Copy link

calumsult commented Oct 27, 2020

In the scanImage function in the decoder there's this bit:

const result = processPixel.call(this, x, line); if (result === false) { return; }

...but processPixel is defined as returning void, hence the if statement will never evaluate to true. Any idea what was intended with that code? I can submit a pr and fix it, but just glancing at it I'm not sure what the intent was. Thanks!

@hipstersmoothie
Copy link
Collaborator

it's been awhile since I've looked at this code. def seems like it could be removed. feel free to make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants