Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility #10

Open
cowboyd opened this issue Nov 10, 2020 · 1 comment
Open

Windows compatibility #10

cowboyd opened this issue Nov 10, 2020 · 1 comment

Comments

@cowboyd
Copy link

cowboyd commented Nov 10, 2020

馃憢 Hi there, we're using shellwords in@effection/node and it's been really great so far. I noticed that the last major change to this was eight years ago. Amazing how software can keep going and going!

https://github.com/thefrontside/effection/blob/v0/packages/node/src/exec.ts#L18

Anyhow, we're looking to add Windows support to this library and noticed that shellwords, when splitting a command on windows removes all \ characters which is the path separator on windows. So, for example:

\Users\cowboyd\Code\bigtest\node_modules\.bin\ts-node is converted to UserscowboydCodebigtestnode_modules.bints-node`

I'd be happy to submit a PR to fix this if you'd be willing to release it. Alternatively, we'd also be happy to take over maintenance of this repository and npm package if you'd be willing to donate it. Let me know and thanks again!

@jimmycuadra
Copy link
Owner

Hi! Sure, I'd be happy to take a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants