Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ReScript 11.0 if not compatible #51

Open
jihchi opened this issue Jan 13, 2024 · 1 comment
Open

Add support for ReScript 11.0 if not compatible #51

jihchi opened this issue Jan 13, 2024 · 1 comment

Comments

@jihchi
Copy link
Owner

jihchi commented Jan 13, 2024

See announcement blog post for more details.

@r17x
Copy link

r17x commented Jan 23, 2024

I have been try vite-plugin-rescript with rescript v11.0.1.

I saw <rootProject>/lib/src (compiled) like this

  lib
    ◌ bs
      ◌ src
    │ │  ◌ index.ast
    │ │  ◌ index.cmi
    │ │  ◌ index.cmj
    │ │  ◌ index.cmt
    │ └  ◌ index.d
    │  ◌ build.ninja
    └  ◌ install.ninja

So, This plugins on ReScript v11 running well for the compilation side but have a little problem when run dev-server (cannot load index.bs.js) with createReScriptPlugin() without loader options

{
  loader:  {
    output: ".",
    suffix: ".bs.js" // same with suffix in rescript.json
  }
}

Information

// package.json
  "dependencies": {
    "@jihchi/vite-plugin-rescript": "^5.5.0",
    "@rescript/core": "^0.6.0",
    "@rescript/react": "^0.12.0",
    "@vitejs/plugin-react-swc": "^3.5.0",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "rescript": "^11.0.1",
    "rescript-chakra": "1.2.0-next.11",
    "rescript-vitest": "^1.3.0",
    "rescript-webapi": "^0.9.1",
    "vite": "^5.0.12",
    "vitest": "^1.2.1"
  }


// rescript.json
{
  "name": "c0FF33",
  "uncurried": false,
  "sources": [
    {
      "dir": "src",
      "subdirs": true
    },
    {
      "dir": "tests",
      "type": "dev",
      "subdirs": true
    }
  ],
  "package-specs": [
    {
      "module": "es6",
      "in-source": true
    }
  ],
  "suffix": ".bs.js",
  "jsx": {
    "version": 4,
    "mode": "automatic"
  },
  "bs-dependencies": [
    "@rescript/react",
    "@rescript/core",
    "rescript-webapi"
  ],
  "bs-dev-dependencies": [
    "rescript-vitest"
  ],
  "bsc-flags": [
    "-open RescriptCore"
  ]
}


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants