Show page number or save marks on disk

[henkye]

Hi, jfbview is actually very neat viewer.
I'd love to have it one more feature:

• ability to show current page.

Why? I'd love to continue reading book another day from last read page. This way, i could note page number somewhere and then jump right to it.

What would also solve this would be permanent marks between jfbviews reexecutions. But i guess, this would be rather more complicated.

I actually looked at code, and was lost. I do some higher level programming and a little bit of plain C, but this is complete gibberish for me :)

[henkye]

Well, i was so inspired, i've made a patch for it:

--- a/src/viewer.cpp    2020-05-28 01:23:54.000000000 +0200
+++ b/src/viewer.cpp    2020-08-18 11:37:14.449219924 +0200
@@ -152,6 +152,14 @@
     _render_cache.Prepare(
         RenderCacheKey(page + 1, zoom, _state.Rotation, _state.ColorMode));
   }
+
+  // 7. Write page number to file.
+  FILE*        filePointer1;
+  filePointer1 = fopen("/tmp/jfbview-last-page", "w");
+  if (filePointer1 == NULL) fprintf(stderr, "Warning: error opening file: '/tmp/jfbview-last-page'\n");
+
+  fprintf(filePointer1, "%d\n", ++page);
+  fclose(filePointer1);
 }

 void Viewer::GetState(Viewer::State* state) const {

Then, you can wrap around something like this:

#
# $obj is path to PDF file
#
function jfb() {
	read sum none < <(sha256sum <<< "$obj")

	read _sum num < <(grep "^${sum}" ~/.jfb-history)

	if [[ -n "$num" ]]; then
		jfbview -p "$num" "$obj"
	else
		jfbview "$obj"
	fi

	( grep -v "^${sum}" ~/.jfb-history; echo "$sum	$(cat /tmp/jfbview-last-page)" ) > /tmp/.jfb-history
	mv -f /tmp/.jfb-history ~/.jfb-history
}

In this combination, it will:

• save last open page of PDF to file
• automatically start on that page next time you open PDF

Just like Evince do by default.

It's rather crude from style perspective, but should be safe to use.

[henkye]

fix + show page number:

  // 7. Write page number to file.
  FILE*	filePointer1;
  filePointer1 = fopen("/tmp/jfbview-last-page", "w");
  if (filePointer1 == NULL) fprintf(stderr, "Warning: error opening file: '/tmp/jfbview-last-page'\n");

  fprintf(filePointer1, "%d\n", page + 1);
  fclose(filePointer1);
  printf("\033[0;0H");
  printf("%d\n", page + 1);