Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic reload when file changes #13

Open
jichu4n opened this issue Jan 24, 2017 · 3 comments
Open

Automatic reload when file changes #13

jichu4n opened this issue Jan 24, 2017 · 3 comments

Comments

@jichu4n
Copy link
Owner

jichu4n commented Jan 24, 2017

Feature request: Automatically reload a file when the file changes on disk. This is useful e.g. for LaTeX editing.

@maandree
Copy link
Contributor

Isn't the 'e' key binding enough. Seems like adding this feature adds a lot of complexity for almost no gain, and it's not even certain that the user wants the file to reload. The user may for example want to have the old version in one VT and the new version in the other VT so that they can be compared.

If you add this, not only do you have to add a thread that waits on inotify, you also need to stop it from drawing if the it's VT is not in the foreground.

@jichu4n
Copy link
Owner Author

jichu4n commented Jan 26, 2017

Thanks a lot for weighing in! This was requested by another user who wanted this behavior (and didn't want to press "e" each time), but you're absolutely right in that it would cause undesirable behavior in many other cases. So I guess it should be optional and disabled by default.

@WuerfelDev
Copy link

Got it working.
Need to clean up the code and will push soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants