Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic pose graph freezing #63

Open
richard-warren opened this issue Aug 23, 2020 · 2 comments
Open

Cyclic pose graph freezing #63

richard-warren opened this issue Aug 23, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@richard-warren
Copy link

richard-warren commented Aug 23, 2020

When the pose graph is cyclic (e.g. A->B->C->A), the while loop in graph_to_edges is infinite. I solved this in my fork by detecting cycles and giving them all their own edge group label.

It was also necessary to change this:
edge_confidence = edge_confidence[..., 1:]
to this:
edge_confidence = edge_confidence[..., lines>=0].

I believe the former assumes the first confidence map corresponds to the parent of all parents. In cycles no such parent exists, so all the confidence maps should be shown. I'm sure you will have more elegant solutions to this problem. Please let me know if you have some ideas. Thanks!

@stale
Copy link

stale bot commented Aug 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue has been inactive for 7 days label Aug 30, 2020
@stale
Copy link

stale bot commented Sep 6, 2020

This issue has been automatically closed because it has not had recent activity.

@stale stale bot closed this as completed Sep 6, 2020
@jgraving jgraving added bug Something isn't working and removed stale Issue has been inactive for 7 days labels Sep 7, 2020
@jgraving jgraving reopened this Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants