Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behavior from draw_graph function in keypoints.py #52

Open
ghost opened this issue Apr 28, 2020 · 2 comments
Open

Strange behavior from draw_graph function in keypoints.py #52

ghost opened this issue Apr 28, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Apr 28, 2020

Hi!
I've been trying to train a model on a human foot keypoint dataset using deepposekit. I was visualizing the skeleton and keypoint confidence graphs produced by the TrainingGenerator and noticed that certain parts of the skeleton aren't visible - in particular, the part from the big toe to the heel. The keypoints are in the order [left big toe, left little toe, left heel, right big toe, right little toe, right heel] so I've defined my graph to be [2, 2, -1, 5, 5, -1]. The result of this is that line 89 in utils/keypoints.py:

edge_confidence = edge_confidence[..., 1:]

cuts off the edge confidence from the big toe to the heel that was just computed. In my particular case I was able to fix the issue by replacing the line with edge_confidence = edge_confidence[..., :-1] but this obviously won't work for every graph. I'm wondering if this is a bug or if perhaps I've defined my graph in some unexpected way.

I also noticed that draw_graph doesn't deal with unlabelled keypoints and will draw lines from labelled to unlabelled keypoints (which are located at [-99999, -99999]). Is this correct?

Thanks!

@stale
Copy link

stale bot commented May 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue has been inactive for 7 days label May 5, 2020
@jgraving
Copy link
Owner

jgraving commented May 6, 2020

Yes there may be a bug with the graph drawing functionality. Will have to look into it further

@stale stale bot removed the stale Issue has been inactive for 7 days label May 6, 2020
@jgraving jgraving added the bug Something isn't working label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant