Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect table cell size when changing units to mm #4360

Open
2 tasks done
FarSeeing opened this issue Apr 27, 2024 · 1 comment
Open
2 tasks done

Incorrect table cell size when changing units to mm #4360

FarSeeing opened this issue Apr 27, 2024 · 1 comment
Assignees

Comments

@FarSeeing
Copy link

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.

If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.

Describe the bug
When you change units to mm and start changing table cell size - the result is incorrect

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://app.diagrams.net/, create a diagram
  2. Add a table
  3. Select any table cell (see screenshot 1 - the width input has a value of 60pt)
  4. Switch units to mm (View - Units - Millimeters, see screeshot 2 - the width input now has a value of 15.2mm)
  5. Try changing table cell size (width/height) in the Arrange tab by clicking buttons next to the input
  6. See table cell sze jumping ( (see screenshot 3 - when decreasing width the value jumps to 3.8mm)

Expected behavior
The table cell size is properly changed

Screenshots
image
image
image

draw.io version (In the Help->About menu of the draw.io editor):

  • draw.io version 24.3.1

Desktop (please complete the following information):

  • OS: any
  • Browser any
  • Browser Version any

Smartphone (please complete the following information):

  • Device: any
  • OS: any
  • Browser any
  • Version any

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

  • yes

Additional context
Add any other context about the problem here.

@FarSeeing
Copy link
Author

I beliven the issue is the missing fromUnit call for the value variable here (and the same should be added in heightUpdate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants