Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic generation of PDF #102

Open
bjornamr opened this issue Mar 19, 2021 · 9 comments
Open

Automatic generation of PDF #102

bjornamr opened this issue Mar 19, 2021 · 9 comments

Comments

@bjornamr
Copy link

Hi

So the basic Idea I have in my fork of your code is that every time I update my resume, the PDF I have linked on my fork is updated.

I have added two things to the fork to make that happen:

  • A github action that renders and commits a PDF every time a change is done on the repo.
  • A PDF link similar to webpage link in config.yml and updated _includes/icon-links.html

You can take a look at my example on https://bjornamr.github.io/resume-template/

Do you want me to do a new fork and include these changes into a pull request?
Maybe update the README.md to explain how to create an access token.

@jglovier
Copy link
Owner

@bjornamr wow, this is really cool!!

How much control do you have over the typography? I wonder if we can use some custom CSS to style the output for the PDF a little more page friendly?

@bjornamr
Copy link
Author

Inserting action.yml file for reference: Action.yml

I am a bit unsure of how much control we have and I am no expert at styling or CSS. I see that puppeteer is what is used behind one of the steps called SetiZ/web_to_pdf_action.

It seems to be based of this repo: fifsky/html-to-pdf-action#1
If you take a look at html to pdf - fifsky it seems like it might be possible to add css and custom fonts.

Would you be able to take a look at the fifsky solution? Maybe it is possible to include some fonts and css to generate better PDF.

@bjornamr
Copy link
Author

I have an Idea @jglovier after looking into this a little. From what I understand, to be able to control the PDF, you would have to write special css / sass for printing.

This would make it possible to have full control and give you the ability to control fonts, placement etc.

@jglovier
Copy link
Owner

jglovier commented Apr 1, 2021

Oh nice! Yeah I can def make a custom stylesheet for the print layout.

Not sure when I'll have some free time to work on it, but it's on my radar now. 👍

@bjornamr
Copy link
Author

Just wanted to add that I figured out a bug in the action, so I updated it in the fork.

@jglovier
Copy link
Owner

Awesome! Thanks for the update, and for your patience. 🙇 Still on my radar.

@alterstep
Copy link

It is going to be added to the upstream project?

@bjornamr
Copy link
Author

bjornamr commented Aug 3, 2021

@jglovier If you could give me some pointers or just some help to start up, I am sure I can help doing some of it.
I am not so well versed on front-end development.

@readycode15
Copy link

fff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants