Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the generator thread safe #214

Open
lsf37 opened this issue Apr 13, 2017 · 1 comment
Open

Make the generator thread safe #214

lsf37 opened this issue Apr 13, 2017 · 1 comment
Assignees
@regisd
Labels
enhancement Feature requests
Projects
Thread-safe Performance

Comments

@lsf37
Copy link
Member

lsf37 commented Apr 13, 2017

As discussed in issue #211 and PR #213, the JFlex generator is currently not thread safe. It'd be nice for larger projects if multiple concurrent build invocations could be supported.

Main thing to change would be the static setup of the Options class, I think.
@lsf37 lsf37 added the enhancement Feature requests label Apr 13, 2017
@regisd regisd added this to TODO in Thread-safe via automation Nov 7, 2017
@regisd regisd self-assigned this Nov 11, 2017
@regisd
Copy link
Member

regisd commented Nov 11, 2017

Interesting project. I'll give it a try.

@regisd regisd mentioned this issue Nov 11, 2017
Closed
@regisd regisd changed the title make the generator thread safe Make the generator thread safe Nov 11, 2017
regisd added a commit to regisd/jflex that referenced this issue Oct 10, 2018
@regisd
Split Main in Main and LexGenerator.
afe31a8 
This is a minor refactoring to support refacotring  jflex-de#214
In the future, LexGenerator.generate() will not be static and have internal state in order to support multithreading.
@regisd regisd mentioned this issue Oct 10, 2018
Merged
regisd added a commit that referenced this issue Oct 10, 2018
@regisd
Split LexGenerator out of Main (#428)
c3ae263 
* Split Main in Main and LexGenerator.
  This is a minor refactoring to support refacotring  #214
  In the future, LexGenerator.generate() will not be static and have internal state in order to support 
  multithreading.

* Update javadoc

*Also  Make Main non instanciable.
regisd pushed a commit that referenced this issue Oct 10, 2018
@traviscibot
Update from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
d243e00 
Initial commit c3ae263
Author: Régis Décamps <regisd@google.com>
Date:   Thu Oct 11 00:42:45 2018 +0200

    Split LexGenerator out of Main (#428)

    * Split Main in Main and LexGenerator.
      This is a minor refactoring to support refacotring  #214
      In the future, LexGenerator.generate() will not be static and have internal state in order to support
      multithreading.

    * Update javadoc

    *Also  Make Main non instanciable.
@regisd regisd added this to In progress in Performance Jan 2, 2021
@regisd regisd removed the performance label Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@regisd regisd

Labels
enhancement Feature requests
Projects
Performance
In progress
Thread-safe
  
TODO
Milestone
No milestone
Development

No branches or pull requests
2 participants
@regisd @lsf37