Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - JMNotificationPermissionManager does not work with iOS 15 #97

Open
cipolleschi opened this issue Sep 1, 2021 · 7 comments
Open
Labels
help wanted Extra attention is needed possible bug Something isn't working

Comments

@cipolleschi
Copy link

Describe the bug
I was building my project with iOS 15 and the library won't build.
Starting from iOS 15, UIApplication.shared.registerForRemoteNotifications() cannot be used in extensions anymore and the error suggests to use a ViewController implementation instead.

To Reproduce
Steps to reproduce the behavior:

  1. Install Xcode 13
  2. Build the project
  3. Observe the build process fail

Expected behavior
The framework should build

Smartphone (please complete the following information):

  • OS: iOS 15
@cipolleschi cipolleschi added the possible bug Something isn't working label Sep 1, 2021
@jevonmao
Copy link
Owner

jevonmao commented Sep 1, 2021

@cipolleschi I will get this fixed ASAP.

@jevonmao jevonmao removed the possible bug Something isn't working label Sep 3, 2021
@jevonmao
Copy link
Owner

jevonmao commented Sep 3, 2021

Follow up, I have attempted to reproduce this bug on Xcode 13, standard SwiftUI project for iOS, targeting iOS 15 and building for iOS 15 simulator. And I am not able to reproduce the error you are talking about. @cipolleschi

@cipolleschi
Copy link
Author

Thanks for being that prompt. We are seeing the error in a project with a WatchOS app associated.
I'll try to create a sample project and to attach it here as reference!

@cipolleschi
Copy link
Author

Hey, this is the example project with the error. Is an Empty WatchOS + iOS project in which I just added the PermissionSwiftUI Swift Package.

Let me know if I can help in any way!
TestPermissionPackage.zip

@jevonmao
Copy link
Owner

jevonmao commented Sep 8, 2021

A little bit busy for the past week, I will try to get to this today.

@github-actions
Copy link

github-actions bot commented Oct 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 9, 2021
@jevonmao jevonmao reopened this Dec 19, 2021
@jevonmao jevonmao added the possible bug Something isn't working label Dec 19, 2021
@jevonmao jevonmao reopened this Aug 7, 2023
@jevonmao jevonmao added help wanted Extra attention is needed and removed stale labels Aug 7, 2023
@jevonmao
Copy link
Owner

jevonmao commented Aug 7, 2023

Will verify all WatchOS(also possibly other less attended to platforms like tvOS) PermissionsSwiftUI APIs, against newest iOS 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed possible bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants