New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Which version of Shampoo is implemented? #452

Open

RylanSchaeffer opened this issue Aug 8, 2022 · 1 comment

RylanSchaeffer commented Aug 8, 2022

The documentation suggests that the Shampoo algorithm comes from the 2018 paper: https://arxiv.org/abs/1802.09568

Is this correct? If so, are there any plan to upgrade to the authors' newer 2021 paper: https://arxiv.org/abs/2002.09018

I believe the newer paper proposes a number of improvements to Shampoo

nreimers commented Oct 8, 2022 •

edited

Would be great to have the updated Shampoo in Pytorch

Edit:
Found some implementation for Shampoo in Pytorch here:
https://github.com/google-research/google-research/tree/master/scalable_shampoo/pytorch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment