Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection management in [F#] equinox-web #7

Closed
bartelink opened this issue Jan 8, 2019 · 1 comment
Closed

Fix connection management in [F#] equinox-web #7

bartelink opened this issue Jan 8, 2019 · 1 comment
Labels
up-for-grabs

Comments

@bartelink
Copy link
Collaborator

TL;DR remove all RunSynchronously as that was only chucked in there in the interests of getting something out

In the C# port in #5, I took the time to make the initialization a) happen as part of startup b) before loading c) without blocking a thread d) without wacky side -effects in the DI
@bartelink
Copy link
Collaborator Author

While it's not perfect, the way things work is much cleaner now in #104
Updating the templates to align with more modern ASP.NET Core 6 idioms re removal of type Startup needs to happen at some point but I'm closing it for now as it's Good Enough

There may also be a point in time when oskardudycz/EventSourcing.NetCore#84 either presents a better example, or we backport the patterns evolving in there to here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartelink