Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greasemonkey v4: xmlHttpRequest.open no longer accept path without protocol and host #372

Open
jesus2099 opened this issue Dec 12, 2017 · 8 comments

Comments

@jesus2099
Copy link
Owner

Still works in Vivaldi but I’ll make a work‐around so that it works in both.

@jesus2099
Copy link
Owner Author

It seems to be a Greasemonkey v4 for Firefox v57 bug, actually (#369).

@jesus2099 jesus2099 reopened this Dec 14, 2017
jesus2099 added a commit that referenced this issue Dec 14, 2017
Not yet completely fixed though (#369)
@jesus2099 jesus2099 changed the title Loading pathname (without https?://musicbrainz.org) does not work in Firefox v57 Greasemonkey v4: xmlHttpRequest.open no longer accept path without protocol and host Dec 15, 2017
@jesus2099
Copy link
Owner Author

jesus2099 commented Dec 15, 2017

I have reopened the ticket as several other scripts should be blocked by this GM v4 regression (greasemonkey/greasemonkey#2771).
If they fix it, I’ll revert my changes.

@jesus2099
Copy link
Owner Author

I think I have work arounded all my scripts now.
I leave this ticket open to revert those changes once the regression is fixed by Greasemonkey.

jesus2099 added a commit that referenced this issue Jan 4, 2018
jesus2099 added a commit that referenced this issue Jan 4, 2018
@Martii
Copy link
Contributor

Martii commented Jan 7, 2018

@jesus2099
Does 4.2beta1 work for you? It does not for me... it seems to break the xhr in my scripts completely. I do see a PR upstream at 2792 awaiting though.

@jesus2099
Copy link
Owner Author

The PR seems to be solely about the async parameter.
Beta version is supposed to work with our /paths.
I don’t really use Firefox but, as soon as I have some time, I’ll install their beta version too and revert my change on some scripts.
But I have not done it yet.

@Martii
Copy link
Contributor

Martii commented Jan 10, 2018

Seems to be functional in 4.2beta2 now. Most likely that commit was the repair needed. Don't see any other related commits that could have unbusted it.

@jesus2099
Copy link
Owner Author

Thanks very much @Martii.
I will wait for the release and revert my work-around. 😁

@jesus2099 jesus2099 added this to the 2020 milestone Feb 1, 2019
jesus2099 added a commit that referenced this issue Aug 21, 2019
Not yet completely fixed though (#369)
jesus2099 added a commit that referenced this issue Aug 21, 2019
jesus2099 added a commit that referenced this issue Aug 21, 2019
jesus2099 added a commit that referenced this issue Aug 21, 2019
Not yet completely fixed though (#369)
jesus2099 added a commit that referenced this issue Aug 21, 2019
jesus2099 added a commit that referenced this issue Aug 21, 2019
jesus2099 added a commit that referenced this issue Aug 21, 2019
Not yet completely fixed though (#369)
jesus2099 added a commit that referenced this issue Aug 21, 2019
jesus2099 added a commit that referenced this issue Aug 21, 2019
@jesus2099
Copy link
Owner Author

I tried coming back to relative path for xhr.open() and it worked in Greasemonkey.
I will make sure it still works in Violentmonkey and Tampermonkey before reverting everywhere.

@jesus2099 jesus2099 reopened this Mar 18, 2021
@jesus2099 jesus2099 modified the milestones: 2020, 2021 Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants