Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show skipped filenames as "skipped" in yellow #9

Open
ljharb opened this issue Sep 11, 2017 · 9 comments
Open

Show skipped filenames as "skipped" in yellow #9

ljharb opened this issue Sep 11, 2017 · 9 comments

Comments

@ljharb
Copy link
Collaborator

ljharb commented Sep 11, 2017

I'd like to see, alongside green PASS and red FAIL, a yellow SKIP when a file is eslintignored (to match up with the nice new skip count).

It'd also be nice if there was an option to suppress reporting these skipped tests (but showing them by default).

@rogeliog
Copy link
Member

I'm not sure if Jest's reporter provides this feature, I think it doesn't but I might be wrong... If this is the case, then it would be harder to implement this because it might require changes in facebook/jest

@rogeliog
Copy link
Member

One thing that might help to mitigate the issue is adding the files/globs to testPathIgnorePatterns

@ljharb
Copy link
Collaborator Author

ljharb commented Sep 12, 2017

I don't want to duplicate the contents of .eslintignore tho - it totally would be nice to have the runner count up the number of ignored files, add that as a skip count (and explicit SKIP entries), and then use them in testPathIgnorePatterns to make the eslint run even faster :-D

@rogeliog
Copy link
Member

I agree, this would be great!

@cpojer there is no way that this could be achieved in the current version of Jest right?

@ljharb
Copy link
Collaborator Author

ljharb commented Sep 12, 2017

Don't pending tests show up in yellow in jest? That's what I'd assume ignored files would show up as.

@cpojer
Copy link

cpojer commented Sep 12, 2017

Yeah, I think this should work if in the eslint runner you report all tests within a file as skipped.

@rogeliog
Copy link
Member

rogeliog commented Sep 12, 2017

Hmmm, I think I'm missing something sorry 😞

Isn't it that it could either show this when skipping all the tests
screen shot 2017-09-12 at 9 59 28 am

or this when skipping the test suite?
screen shot 2017-09-12 at 10 01 36 am

@ljharb
Copy link
Collaborator Author

ljharb commented Sep 12, 2017

In the case of the eslint runner, there's only 1 test per file, and 1 file per test suite, so both should be marked skipped, no?

@cpojer
Copy link

cpojer commented Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants