Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set eslint as a peer dependency #54

Closed
SimenB opened this issue Sep 28, 2018 · 1 comment
Closed

Set eslint as a peer dependency #54

SimenB opened this issue Sep 28, 2018 · 1 comment

Comments

@SimenB
Copy link
Member

SimenB commented Sep 28, 2018

This came up in #49. Right now we depend on ESLint. Not sure exactly why TBH, but my guess is that so we have something to fall back to if we cannot find the user's version.

I think it makes more sense to add it as a peer dependency (with range on both eslint 4 and 5 probably), then we can just use require and not have to deal with it manually.

We can also add a peer dep range to Jest as well, especially seeing as #53 requires Jest 23

EDIT: Should resolve #41 I think

@ljharb
Copy link
Collaborator

ljharb commented Sep 28, 2018

A peer dep for both is definitely the proper solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants