Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cliOptions: { quiet: true }unexpectedly reports warnings #211

Closed
ken-kenware opened this issue Sep 18, 2023 · 2 comments · Fixed by #212
Closed

cliOptions: { quiet: true }unexpectedly reports warnings #211

ken-kenware opened this issue Sep 18, 2023 · 2 comments · Fixed by #212

Comments

@ken-kenware
Copy link
Contributor

I have a project where we use { cliOptions: { quiet: true }} in order to not report warnings in CI.

We noticed recently that if a file had an error in it, CI would report all of the errors/warnings as errors (similar to this discussion: #21). However, because I have quiet set to true, I would expect that ESLint should only report the errors.

I did some digging and it looks like the issue is happening because on this line, ESLint is properly filtering the events as expected:
https://github.com/jest-community/jest-runner-eslint/blob/main/src/runner/runESLint.js#L238

But then we pass the unfiltered report here: https://github.com/jest-community/jest-runner-eslint/blob/main/src/runner/runESLint.js#L249

I'm happy to submit a PR to fix!

@SimenB
Copy link
Member

SimenB commented Sep 18, 2023

PR very much welcome 🙂

@nsunga
Copy link

nsunga commented Oct 24, 2023

EDIT: I think I got it to work -- configuration done in package.json helped and also installing fresh node_modules

@ken-kenware hello 👋

is it possible for you to break down your file directory structure for how this runner works?

Im not sure how cliOptions is injected into the jest.config.js thats passed into jest -- I might be misunderstanding the current README for the setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants