Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rendered expiry year format to be configured (mm/yyyy vs. mm/yy) #36

Closed
iwootten opened this issue Jun 6, 2014 · 6 comments
Closed

Comments

@iwootten
Copy link
Contributor

iwootten commented Jun 6, 2014

If would be great if when a form uses the format "mm/yyyy" for an expiry date, it could be displayed as four dots on the card.

I would do this myself, but haven't got time to learn coffeescript right now. :)

@jessepollak
Copy link
Owner

So, are you saying that you'd like a configuration open to differentiate between it rendering as mm/yyyy and mm/yy?

@jessepollak jessepollak changed the title Allow expiry year length to be Configured Allow expiry year length to be configured Jun 6, 2014
@jessepollak jessepollak changed the title Allow expiry year length to be configured Allow rendered expiry year format to be configured (mm/yyyy vs. mm/yy) Jun 6, 2014
@iwootten
Copy link
Contributor Author

iwootten commented Jun 6, 2014

Yup. Looks strange to enter 4 digits, show 4 digits, but not 4 placeholders. Currently I've just modified this in my own setup and had adjusted the width of the div to cope with it.

@jessepollak
Copy link
Owner

Great. If you get the energy to try it out in coffeescript (it's really easy), would love a PR. If not, I'll look into it when I have a sec.

@JacquesLoubser
Copy link
Contributor

Do I misunderstand? If I type in mm/yy it renders as mm/yy and if I enter mm/yyyy it renders as mm/yyyy

@iwootten
Copy link
Contributor Author

@JacquesLoubser - that's the rendering of the input text on the card. What the issue refers to is the number of dots displayed on the card prior to text having been entered, which is fixed at two characters for the year.

@jessepollak
Copy link
Owner

Thanks for the feedback :)

This is possible with the values option in the configuration — let me know if you have any issues with that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants