Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordIO Stream should return Async::Ready(None) instead of Async::NotReady #13

Open
jeschkies opened this issue May 8, 2018 · 1 comment

Comments

@jeschkies
Copy link
Owner

jeschkies commented May 8, 2018

According to the Tokio Chat example we should not return Async::NotReady unless the inner stream does. We violate this in client.rs:67. We should return Async::Ready(None) instead.

@jeschkies
Copy link
Owner Author

This contradicts a little https://docs.rs/futures/0.1.21/futures/stream/trait.Stream.html#associatedtype.Error. According to the docs a stream is considered finished when it returns Async::Ready(None).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant