Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve graphs for "tight races" between individuals #88

Open
jeroenheijmans opened this issue Jan 11, 2023 · 1 comment
Open

Improve graphs for "tight races" between individuals #88

jeroenheijmans opened this issue Jan 11, 2023 · 1 comment
Labels
enhancement Improve an existing feature. requires investigation Something still to be investigated

Comments

@jeroenheijmans
Copy link
Owner

Introduction

In another issue @SuperTux88 commented on the recent updates to graphs where the "Logged in User" (if known) gets highlighted with a bit thicker line. They said:

I still have one leaderboard where I was racing with another person and we were pretty close for multiple days, but the new percentage view also already improves the visibility with close lines and it's visible as soon as we are 2 or more points apart. So probably good enough.

But continues:

I just had another idea: what if the highlighted line is done with hovering over the names/lines? That could help to also quickly highlight other lines in a big board (without needing to disable everybody else). But I also don't know how easy that is and what it does to performance on big boards? 🤔 So not sure if it's worth it, but if you think it is doable and could be useful, I can create a separate issue about it.

I think it's fair to put in some extra effort for users who are part of a "tight race". I think they are the "Power Users" of this browser extension: perhaps a small part of the user base, but also those who use it the most or to the max.

The Issue

Could we improve the situation for folks in a "tight race"? Can we somehow undo the fact that "only a thicker line for logged in users" now overshadows such a tight race? Without giving up the benefits of the extra highlight?

There's plenty of options to investigate, including but not limited to:

  • (as per commenter's suggestion) doing the highlight by hovering over legend items and/or lines
  • (the original suggestion) making this a per-user setting after all
  • detecting "tight races" and highlighting everyone involved in that tight race
  • investigate if the Chart.js samples and features offer another way to handle this
  • introduce extra graphs or graph types (e.g. the "tight race" graph?)
  • etc.

I welcome input and suggestions, either written or as proof of concepts. Take care however not to go overboard with a PR before we know if a direction is one we want to end up going in.

@jeroenheijmans jeroenheijmans added enhancement Improve an existing feature. requires investigation Something still to be investigated labels Jan 11, 2023
@jeroenheijmans
Copy link
Owner Author

TBD if this can and should be part of #79 (2023 udpates), which also depends on whether a 2023 edition of AoC will happen at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing feature. requires investigation Something still to be investigated
Projects
None yet
Development

No branches or pull requests

1 participant