Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use addon css #17

Open
jeroenheijmans opened this issue Dec 8, 2018 · 2 comments
Open

Refactor to use addon css #17

jeroenheijmans opened this issue Dec 8, 2018 · 2 comments
Labels
technical debt Hacks and workarounds that will hurt development later.

Comments

@jeroenheijmans
Copy link
Owner

jeroenheijmans commented Dec 8, 2018 •
edited

Surely we can refactor to use css classes and pack a css file with the addon.

As an added bonus, the current "responsiveness" placing two charts next to eachother can start responding to resize events.

PS. There's a advent-of-code-charts channel in the contributing.today Discord where I'll be if anyone has hacktoberfest-related questions!
@jeroenheijmans jeroenheijmans added technical debt Hacks and workarounds that will hurt development later. up-for-grabs Is most likely easy to pick up for someone new to the code. labels Dec 8, 2018
@jeroenheijmans jeroenheijmans mentioned this issue Dec 9, 2018
Closed
@jeroenheijmans jeroenheijmans removed the up-for-grabs Is most likely easy to pick up for someone new to the code. label Dec 30, 2022
@jeroenheijmans jeroenheijmans self-assigned this Jan 5, 2023
@jeroenheijmans
Copy link
Owner Author

This is a good candidate... if a 2023 edition of AoC will happen. Will revisit this issue in fall when we know more.

@jeroenheijmans jeroenheijmans removed their assignment Jan 7, 2023
@jeroenheijmans jeroenheijmans mentioned this issue Nov 28, 2023
Merged
@jeroenheijmans
Copy link
Owner Author

In #94 a start was made, some of the newer features were done with a CSS file. We can build on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt Hacks and workarounds that will hurt development later.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeroenheijmans