Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Days won't show up in tables and some charts if no member has completed part 2 yet #100

Open
AlexandraDorey opened this issue Dec 21, 2023 · 2 comments
Labels
bug Something's broken!
Milestone

Comments

@AlexandraDorey
Copy link

Note javascript is not really a lang I do a lot of dev in and I skimmed the code for anything obvious but couldn't see much. We have a situation where nobody has managed to get the 2nd start for day 21 yet on our leader board, and as a result no stats seem to be showing up for that day, looking through the code there are a couple places it looks like you loop on the count of the 'a' medals so if that collection is zero it's plausible nothing would happen? That's my best guess, anyway if you have a chance to look at it that'd be awesome, and Thanks for the great addon :)

@jeroenheijmans
Copy link
Owner

Hi there, and thanks for taking the time to write up an issue!

I think you're right. Days where no Leaderboard Member has completed 2 stars yet, will be excluded from most portions of the addon. At the least the medals overview and delta times work this way. There were a few 2023 days already where I noticed the same on my company's leaderboard 😅

Originally this was intentional, but I think it's better to change this if possible.

  • Medals can show the "border" for part 1 medals already
  • Delta times cannot show anything meaningful, except add an empty column for the day that was obviously "started"
  • The line graphs I will have to check and see what happens in this case
  • The log10 (third) graph.... I'm not even sure what it means anymore 😂 so we'll see
  • The final bar chart definitely already shows part 1 stars for days where no one has gotten part 2 yet, so that already works I think?

It is likely that fixes for this will come only after Dec 2023, between work, completing the puzzles myself, and finishing up the AoC Survey Results, I don't think there's room to fix it this year. Hope that makes sense!

Happy puzzling either way!

@jeroenheijmans jeroenheijmans added the bug Something's broken! label Dec 21, 2023
@jeroenheijmans jeroenheijmans added this to the 2024-updates milestone Dec 21, 2023
@jeroenheijmans jeroenheijmans changed the title Stats Not showing up a day Days won't show up in tables and some charts if no member has completed part 2 yet Dec 21, 2023
@leyanlo
Copy link
Contributor

leyanlo commented Dec 21, 2023

+1. Day 21 was (continues to be) brutal 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's broken!
Projects
None yet
Development

No branches or pull requests

3 participants