Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private room password prompt #274

Closed
brentonv opened this issue Apr 26, 2024 · 11 comments
Closed

Private room password prompt #274

brentonv opened this issue Apr 26, 2024 · 11 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brentonv
Copy link

Could you please show the private room password prompt before launching the room. Currently if it's clicked in error there is no way to escape the prompt without reloading the page.

It would be more user friendly if the prompt was dismissible, either by clicking a close icon in the top-right corner, clicking outside the dialog or pressing the escape key.

Thanks,

@jeremyckahn
Copy link
Owner

Hi @brentonv, thanks for raising this. I agree that the UX for private rooms is a little awkward. I think updating the password prompt dialog with a "go back" button that brings the user to the Home page might be all that's needed here. What do you think?

@jeremyckahn jeremyckahn added the enhancement New feature or request label Apr 26, 2024
@brentonv
Copy link
Author

Yeah I did some testing with closing the prompt and considered that as a simple option instead of requiring some rewrite. Personally I would prefer if the prompt was presented first, but up to you

@jeremyckahn
Copy link
Owner

Personally I would prefer if the prompt was presented first

The idea with the current UX is that the password dialog appears in the shareable private room link. It would be possible to show the password dialog before the user is routed from the Home screen to the Private Room screen and also support the current UX, but that adds a bit more complexity. We could consider that in a future iteration, but for now it seems that the simplest solution is to add a "go to home screen" button to the current password dialog.

I'm pretty busy with other tasks at the moment, but I can add this when I have time. It shouldn't be a big lift to implement this, so others are welcome to submit a PR to add it before I get around to it.

@jeremyckahn jeremyckahn added the good first issue Good for newcomers label Apr 27, 2024
@brentonv
Copy link
Author

the simplest solution is to add a "go to home screen" button

All that's needed is simple "x" in the top right corner, which will go back to the home screen when clicked

@jeremyckahn
Copy link
Owner

All that's needed is simple "x" in the top right corner, which will go back to the home screen when clicked

This seems like a confusing UX to me. Generally speaking, I don't think that dismissing a modal should cause a navigation. A button that explicitly states what will happen if pressed seems more straightforward.

@Con198811
Copy link

Hello Jeremy I ended up in this site through messing around with Pythonista web scraping 😂

@brentonv
Copy link
Author

I ended up in this site through messing around with Pythonista web scraping 😂

I used Google🤣

@brentonv
Copy link
Author

brentonv commented May 1, 2024

@jeremyckahn I just realized that any changes made will affect how the embedded code works, so it's probably best to only include your "go to home screen" button when initiated from the main page..

@jeremyckahn
Copy link
Owner

I just realized that any changes made will affect how the embedded code works

I hadn't thought of that! I was just focusing on the UX. But I think you're right here; it's probably best to stick with a "go to home screen" button. I think the new button should only show when Chitchatter isn't running in "embedded" mode, as the embedded experience should never take the user to the Home screen.

@jeremyckahn
Copy link
Owner

@brentonv this is done and shipped now. Great idea to add this!

@brentonv
Copy link
Author

@jeremyckahn thanks mate👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

No branches or pull requests

3 participants