Skip to content
This repository has been archived by the owner on Apr 30, 2020. It is now read-only.

Add a method to return the count by period with interval #12

Open
jeremyFreeAgent opened this issue Dec 24, 2012 · 5 comments
Open

Add a method to return the count by period with interval #12

jeremyFreeAgent opened this issue Dec 24, 2012 · 5 comments
Milestone

Comments

@jeremyFreeAgent
Copy link
Owner

See #11 for the start of the talk.

@stephpy
Copy link
Contributor

stephpy commented Dec 24, 2012

I'm +1 on @shouze comment:

bitDatePeriod needs to be renamed into bitDateRange as it looks confusing ATM
A new method needs to be introduced, something like countByPeriodWithInterval(\DateTime $from, \DateTime $to, \DateInterval $interval). This method should return an array or any iterable object collection.

@stephpy
Copy link
Contributor

stephpy commented Dec 24, 2012

On second point. Why does not use

countByPeriod(\DatePeriod $datePeriod) ?

@jeremyFreeAgent
Copy link
Owner Author

There is no more bitDatePeriod, it's bitDateRange now.
🔨

@jeremyFreeAgent
Copy link
Owner Author

DatePeriod is a holy crap. I think it's a trainee who made it...
🎒

@stephpy
Copy link
Contributor

stephpy commented Dec 24, 2012

Yes, let's overwrite it :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants