Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Dockerized tests are not runnable on macOS #411

Open
mrmeszaros opened this issue Jul 23, 2023 · 0 comments · May be fixed by #413
Open

The Dockerized tests are not runnable on macOS #411

mrmeszaros opened this issue Jul 23, 2023 · 0 comments · May be fixed by #413

Comments

@mrmeszaros
Copy link

Currently there is a plethora of issues when executing .run-tests.sh.

First of all, the created image tag (jenv:tests) does not match the started container's (jenv:test).

Secondly, in the Dockerfile the packages specify x86_64 and i686 as their architecture: this will currently break the docker build on any other architectures (as mine: aarch64).

Thirdly, java-1.6.0-openjdk is no longer available - it should be removed.

Onto the tests:

  • the java 1.6 needs to be removed
  • the java patch versions will likely break the build (at least one breaks AFAIK) - it would need to be addressed
  • currently jenv cannot seem to add the graalvm java, which breaks all of the setting_versions.bats tests

Last but not least:

  • for some odd reason, I have an ephemeral issue where the jenv in the container does not recognize the shell command and breaks all adding_jdks.bats tests
  • it is extra weird, as it worked just 5 hours ago, did not work 5 minutes ago, and now it works again.
  • It might be related to the jenv-sh-$command magic - that I do not understand.

PS: Sorry, I had logs to back up my claim and everything, but before I posted it, chrome restarted and ate my input :(
PPS: I think Imma create a PR for some of the fixes I know would work.

@mrmeszaros mrmeszaros linked a pull request Jul 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant