Implicit conversion from float ... to int loses precision (PHP 8.1)

[diggy]

Error with PHP 8.1.11 on this line

optimus/src/Optimus.php

Line 68 in a062ac0

return (($value * $this->prime) & $this->max) ^ $this->xor;

, e.g.

Implicit conversion from float 3.802099463828355E+21 to int loses precision

[jenssegers]

I'm not fully up to date with the recent changes in PHP versions. Would casting everything explicitly to (int) fix the warning?

Would you be up for making a PR?

[diggy]

@jenssegers I'm not sure, some quick Googling seems to indicate that explicit casting or conversion is needed, but I wouldn't want to make the call and possibly break things here :)

• https://stackoverflow.com/a/71534708
• https://php.watch/versions/8.1/deprecate-implicit-conversion-incompatible-float-string

[MissCoraline]

maybe the real reason is that you tried to encode a number bigger than maxid ? actually, you should not do that, otherwise you won't be able to decode from encoded value.