Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline function 'googleStorageBuildLogUpload' not working in post block #89

Open
sbienkow opened this issue Sep 4, 2019 · 1 comment · May be fixed by #175
Open

Pipeline function 'googleStorageBuildLogUpload' not working in post block #89

sbienkow opened this issue Sep 4, 2019 · 1 comment · May be fixed by #175
Labels
bug

Comments

@sbienkow
Copy link

sbienkow commented Sep 4, 2019

See #42
Exactly the same issue, just different build step - googleStorageBuildLogUpload doesn't upload Jenkins log in post steps.

Looks like the fix is simple, but potentially more than just this mentioned step is affected, since only ClassicUploadStep and GoogleCloudStorageUploader have mentions of setForFailedJobs.
cha5on added a commit to cha5on/google-storage-plugin that referenced this issue Dec 28, 2021
@cha5on
Make googleStorageBuildLogUpload work in post
1cc6265 
It is expected that steps in a pipeline post section always run if
specified with an "always" condition.  Change 51fee77 fixed this
behavior for the googleStorageUpload step, and this change similarly
fixes googleStorageBuildLogUpload.

Add a unit test to confirm that this works as intended.

Fixes jenkinsci#89.
cha5on added a commit to cha5on/google-storage-plugin that referenced this issue Dec 28, 2021
@cha5on
Make googleStorageBuildLogUpload work in post
6f7c845 
It is expected that steps in a pipeline post section always run if
specified with an "always" condition.  Change 51fee77 fixed this
behavior for the googleStorageUpload step, and this change similarly
fixes googleStorageBuildLogUpload.

Add a unit test to confirm that this works as intended.

Fixes jenkinsci#89.
cha5on added a commit to cha5on/google-storage-plugin that referenced this issue Dec 28, 2021
@cha5on
Make googleStorageBuildLogUpload work in post
01c83e8 
It is expected that steps in a pipeline post section always run if
specified with an "always" condition.  Change 51fee77 fixed this
behavior for the googleStorageUpload step, and this change similarly
fixes googleStorageBuildLogUpload.

Add a unit test to confirm that this works as intended.

Fixes jenkinsci#89.
@cha5on cha5on linked a pull request Dec 28, 2021 that will close this issue
Open
@cha5on
Copy link
Contributor

cha5on commented Feb 10, 2023

hello, I have an open pullreq for this at #175 ! It's been open since Dec 2021. While I've been maintaining a local build, I'd really love to have this fix in the official plugin, so please review when convenient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make googleStorageBuildLogUpload work in post cha5on/google-storage-plugin
3 participants
@cha5on @sbienkow @stephenashank