Support all the glob formats for the download step #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
force-pushed
the
feature/wildcard-download-support
branch
from
80f0fdf
to
b2f8571
Compare
v1v
commented
May 17, 2020
| @@ -21,7 +21,8 @@ pipeline { | |||
| steps{ | |||
| step([$class: 'DownloadStep', credentialsId: env | |||
| .CREDENTIALS_ID, bucketUri: "gs://${env.BUCKET}/${env.PATTERN}", | |||
| localDirectory: "${env.DIR}/**/*"]) | |||
| localDirectory: "${env.DIR}"]) | |||
There was a problem hiding this comment.
localDirectory requires path relative to the workspace, so wildcards are treated as folders though.
Comment on lines
+84
to
+85
| VirtualFile archivedFile = run.getArtifactManager().root().child("folder/foo.txt"); | ||
| assertTrue(archivedFile.exists()); |
There was a problem hiding this comment.
This particular assert is similar to the ones used in other projects:
Comment on lines
+85
to
+86
| VirtualFile archivedFile = run.getArtifactManager().root().child(pattern); | ||
| assertTrue(archivedFile.exists()); |
There was a problem hiding this comment.
This particular assert is similar to the ones used in other projects:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
### What
Add support for the multiple wildcards, aka using Glob format for the download step
Why
Missing functionality to download subfolders and nested files/folders
Tasks
mvn hpi:runand manually created seems to works as expected.