Make Upload and Download Steps into Custom Steps

[jphartley]

The Google Cloud Storage Plugin offers a build step to upload and download files to and from Google Storage during a build. The current integration of the plugin with Pipeline syntax is sub-optimal since it uses a generic step instead of a custom named step

step([
  $class: 'ClassicUploadStep', 
  credentialsId: env.CREDENTIALS_ID,  
  bucket: "gs://${env.BUCKET}",
  pattern: env.PATTERN
]) 

This should be relatively straightforward to fix simply by annotating the descriptor of the step with @Symbol('nameOfStep'). This will modify it so that a generic step isn't required and it will then also have the benefit that it will immediately start working for declarative pipelines.

[batmat]

cc @craigdbarber for visibility, thanks!

[craigdbarber]

Thanks for the feedback. We already are using this annotation:

google-storage-plugin/src/main/java/com/google/jenkins/plugins/storage/DownloadStep.java

Line 462 in 38f46ec

@Symbol("googleStorageDownload")

google-storage-plugin/src/main/java/com/google/jenkins/plugins/storage/ClassicUploadStep.java

Line 191 in 38f46ec

@Symbol("googleStorageUpload")